[PATCH] D31345: [XRay] [compiler-rt] Unwriting FDR mode buffers when functions are short.

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: test/xray/TestCases/Linux/fdr-mode.cc:3
+// RUN: XRAY_OPTIONS="patch_premain=false xray_naive_log=false xray_logfile_base=fdr-logging-test- xray_fdr_log=true verbosity=1 xray_fdr_log_func_duration_threshold_us=0" %run %t 2>&1 | FileCheck %s
+// RUN: %llvm_xray convert -output-format=yaml -instr_map=%t "`ls fdr-logging-test-* | head -1`" | FileCheck %s --check-prefix=TRACE
 // RUN: rm fdr-logging-test-*
----------------
Did you need to do this after a rebase? I've landed the change that already makes this line actually work, I think?


================
Comment at: test/xray/TestCases/Linux/fdr-mode.cc:62-63
 
-// TRACE: { function }
+// TRACE: function-enter
+// TRACE: function-exit
----------------
The change upstream improves this a bit so that we're actually checking that the stuff is showing up in different threads and matching enters/exits. Consider a rebase?


https://reviews.llvm.org/D31345