[PATCH] D31444: LTO: call getRealLinkageName on IRNames before feeding to getGUID

[Bob Haarman via Phabricator via llvm-commits]

inglorion added a comment.

> static GUID getGUID(StringRef Name, GlobalValue::LinkageTypes Linkage, StringRef FileName);

That crossed my mind as well, but it would need 3 pieces of information, and we have only 1 in LTO::GlobalResolution. Plus the type id awkwardness that pcc mentioned. You also still need to deal with IRNames and linkage names. In other words, having everything go through that static method would reduce the number of getGUID methods from 2 to 1, which is good, but what is the proposal for making sure it is invoked correctly?


https://reviews.llvm.org/D31444