[PATCH] D27051: [X86] Add NumRegisterParameters Module Flag

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 12:44:38 PDT 2017


On Wed, Mar 29, 2017 at 12:30 PM, Nirav Davé <niravd at google.com> wrote:

> Doing so would require non-trivial plumbing of NumRegParameters through
> the llvm IR.
>
> That said, I don't believe there's any reason that we cannot move all the
> flag declarations up to the end of CodeGenModule::CodeGenModule so they're
> all in one place again.
>

Are you sure it requires any complex plumbing? CodeGenOpts is already
available in CodeGenModule::Release. I think you can go ahead and move the
code to set the module flag for consistency.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170329/a2565865/attachment.html>


More information about the llvm-commits mailing list