[PATCH] D31454: [XRay][compiler-rt] Use llvm-xray in FDR mode tests

Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 10:46:16 PDT 2017


kpw added a comment.

LGTM

1. Do these run as part of the "check-xray" target?
2. We should update these to set the function time threshold flag to zero when we merge the unwriting patch in.

I volunteer to write a few supplemental test cases when that lands.

- Sets the threshold very high and checks that no functions appear in the log.
- Sets the threshold high, but have some functions that sleep. Check that invocations are erased when it makes sense and remain when eligible.


https://reviews.llvm.org/D31454





More information about the llvm-commits mailing list