[PATCH] D30536: [tablegen][globalisel] Convert the SelectionDAG importer to a tree walking approach. NFC

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 09:24:31 PDT 2017


ab added a comment.

> If a function always returns an Error, what does it return on success? It would be strange to have an Error that is not an error.

It returns Error::success().  The name is somewhat awkward, but think of it as a replacement for the old-style 'int' return values, or c++ std::error_code.  There are a few examples in http://llvm.org/docs/ProgrammersManual.html#recoverable-errors.


Repository:
  rL LLVM

https://reviews.llvm.org/D30536





More information about the llvm-commits mailing list