[PATCH] D31452: [XRay][compiler-rt] Add an end-to-end test for FDR Logging

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: test/xray/TestCases/Linux/fdr-mode.cc:3
+// RUN: XRAY_OPTIONS="patch_premain=false xray_naive_log=false xray_logfile_base=fdr-logging-test- xray_fdr_log=true verbosity=1" %run %t 2>&1 | FileCheck %s
+// FIXME: %llvm_xray convert -instr_map=%t "`ls fdr-logging-test-* | head -1`" | FileCheck %s --check-prefix TRACE
+// RUN: rm fdr-logging-test-*
----------------
kpw wrote:
> I suspect we'll lose the exit code due to unix pipes returning the final commands exit code.
> 
> If the command returns a TRACE prefix as expected, then crashes, we want a failure.
> If the shell that runs these is guaranteed to be bash, then the pipefail builtin option could help.
Yes, this is currently not doing anything (notice that it's a `FIXME` as opposed to a `RUN`) :)

As soon as we fix the writing of the buffer sizes in the log, we'll be ready to turn this on.


https://reviews.llvm.org/D31452