[PATCH] D31165: [SDAG] Add AllowContract to SNodeFlags

[Adam Nemet via Phabricator via llvm-commits]

anemet added a comment.

In https://reviews.llvm.org/D31165#712632, @spatel wrote:

> In https://reviews.llvm.org/D31165#712564, @anemet wrote:
>
> > @spatel, @arsenm, this is a trivial patch to expose the new FMF to SDAG. Since you guys looked at the rest of the LLVM patches in the set, would you mind reviewing this too?
>
>
> I actually haven't looked at all of the patches. Can you add me to those?


You were already added to the LLVM patches (there is one left for now but I am working on more ;).  I'll add you to the clang ones too.

> This patch LGTM. I made a couple of small suggestions for follow-ups.

Thanks, Sanjay!  I committed the changes you requested (r298962, r298963).

> I don't know if this is addressed in one of the other patches, but we'll want to extend FMF to more than binops...or we won't be able to propagate the contract flag to FMA nodes.

Not, it's not addressed; we can do that later if it's useful.  When is that useful?


Repository:
  rL LLVM

https://reviews.llvm.org/D31165