[PATCH] D31444: LTO: call getRealLinkageName on IRNames before feeding to getGUID

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 28 16:38:47 PDT 2017


inglorion added a comment.

@mehdi_amini, we have other places where we call GlobalValue::getGUID with a name that is not an IR name, e.g. in BitcodeReader.cpp. I wouldn't be opposed to moving to a design where it's harder to pass the wrong kind of name, or even a design where the IR name and the RealLinkageName and the GlobalIdentifier aren't all different things, but that is going to be a larger change. Can we get this fix in in the meantime?


https://reviews.llvm.org/D31444





More information about the llvm-commits mailing list