[PATCH] D31407: [PPC] In PPCBoolRetToInt change the bool value to i64 if the target is ppc64

[Eric Christopher via Phabricator via llvm-commits]

echristo added inline comments.


================
Comment at: test/CodeGen/PowerPC/pr32442.ll:2
+; RUN: llc -mtriple=powerpc64le-linux-gnu -mcpu=pwr8 < %s | FileCheck %s
+
+; CHECK-NOT: clrldi
----------------
Carrot wrote:
> echristo wrote:
> > echristo wrote:
> > > Carrot wrote:
> > > > echristo wrote:
> > > > > Throw the PR number in here as a comment?
> > > > It is contained in the filename.
> > > So it is. Perhaps a more descriptive filename and a link to the PR :)
> > Any reason this can't go into the other file?
> Test case BoolRetToIntTest.ll runs BoolRetToInt pass only, and check the LLVM IR. The extra zero extension is not very obvious at this time, it is explicitly generated at the machine instruction phase.
Aha. That makes sense.

How about BoolRetToIntTest-2.ll then and leave the PR in the comment section?

I realize this seems like a crazy amount of care over file naming, but historically I've found that pr named tests aren't very helpful.


https://reviews.llvm.org/D31407