[PATCH] D31412: Boost unroll threshold for loops reading local memory

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 28 14:13:52 PDT 2017


cfang accepted this revision.
cfang added a comment.
This revision is now accepted and ready to land.

LGTM except the line should be "else if" or begin a newline!



================
Comment at: lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:87
           continue;
+      } if (AS == ASST.LOCAL_ADDRESS) {
+        LocalGEPsSeen++;
----------------
Should this be "} else if  (AS == ASST.LOCAL_ADDRESS)  {


Repository:
  rL LLVM

https://reviews.llvm.org/D31412





More information about the llvm-commits mailing list