[PATCH] D31403: [SDAG] Deal with deleted node in PromoteIntShiftOp

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 28 10:07:48 PDT 2017


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

No more comments from me - LGTM



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1161
     if (!N0.getNode())
       return SDValue();
 
----------------
RKSimon wrote:
> Is there any case where the promotion of N0 will affect N1? Wouldn't shift(N0, N0) do this?
> 
Actually it seems we combine shift(N0, N0) --> 0


https://reviews.llvm.org/D31403





More information about the llvm-commits mailing list