[PATCH] D31407: [PPC] In PPCBoolRetToInt change the bool value to i64 if the target is ppc64

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 28 01:05:11 PDT 2017


Agreed, that's why I said to always assume TM.

On Tue, Mar 28, 2017, 1:02 AM Nemanja Ivanovic via Phabricator <
reviews at reviews.llvm.org> wrote:

> nemanjai added inline comments.
>
>
> ================
> Comment at: lib/Target/PowerPC/PPCBoolRetToInt.cpp:93
> +  Value *translate(Value *V) {
> +    Type *IntTy = Type::getInt32Ty(V->getContext());
> +    if (ST && ST->isPPC64())
> ----------------
> Just a personal preference nit...
> Maybe turn this into a conditional operator for the initialization (rather
> than the assignment in the if).
>
>
> https://reviews.llvm.org/D31407
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170328/4c77cff0/attachment.html>


More information about the llvm-commits mailing list