[PATCH] D31189: [InstCombine] Fix folding of select into phi nodes when incoming element of phi is a vector type

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 27 07:05:54 PDT 2017


anna added inline comments.


================
Comment at: test/Transforms/InstCombine/phi-select-constexpr.ll:1
 ; RUN: opt < %s -S -instcombine | FileCheck %s
 @A = extern_weak global i32, align 4
----------------
sanjoy wrote:
> anna wrote:
> > sanjoy wrote:
> > > Should we rename this file now?
> > Maybe something like `phi-select-const`?
> How about `phi-select-constant`?
agreed. doing as an NFC. 


Repository:
  rL LLVM

https://reviews.llvm.org/D31189





More information about the llvm-commits mailing list