[PATCH] D31277: [X86][MS-compatability]Allow named synonymous for MS-assembly operators

[Marina Yatsina via Phabricator via llvm-commits]

myatsina added inline comments.


================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:685
+    // and if so - invoke the appropriate handler
+    bool onNamedOperator(StringRef Name) {
+      // A named operator should be either lower or upper case, but not a mix
----------------
I don't think it should be part of the state machine. I think this function should move to the parser and be activates as part of ParseIntelExpression.



================
Comment at: test/MC/X86/intel-syntax-bitwise-ops.s:9
     and ecx, 1|2
-// CHECK: andl	$3, %ecx
+// CHECK: andl $3, %ecx
+    and ecx, 1 or 2
----------------
It seems you have a space instead of a tab in all the checks


================
Comment at: test/MC/X86/intel-syntax-bitwise-ops.s:42
+// CHECK: addl $-9, %eax
+    add eax, not 8
----------------
Add a few tests for the upper case as well (AND, OR).
Add some complex case like "(6 and 3) XOR 9"


Repository:
  rL LLVM

https://reviews.llvm.org/D31277