[PATCH] D31385: [XRay] Update FDR log reader to be aware of buffer sizes per thread.

[Keith via Phabricator via llvm-commits]

kpw created this revision.

It is problematic for this reader that it expects to read data from
several threads, but the header or message format does not define
framing. Since the buffers are reused, we can't rely on skipping
zeroed out data as a synchronization method either.

There is an argument that this is not version compatible with the format
the reader expected previously. I argue that since the writer wrote garbage
past the end of buffer record, there is no currently working reader to
compromise.

The corresponding writer change is posted to https://reviews.llvm.org/D31384.


https://reviews.llvm.org/D31385

Files:
  lib/XRay/Trace.cpp
  test/tools/llvm-xray/X86/Inputs/fdr-log-version-1.xray

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31385.93104.patch
Type: text/x-patch
Size: 9690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170327/a460af71/attachment.bin>