[PATCH] D31377: [IR] Share implementation of pairs of const and non-const methods in BasicBlock using the const version instead of the non-const version

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.

During post-commit review of a previous change I made it was pointed out that const casting 'this' is technically a bad practice. This patch re-implements all of the methods in BasicBlock that do this to use the const BasicBlock version and const_cast the return value instead.

I think there are still many other classes that do similar things. I may look at more in the future.


https://reviews.llvm.org/D31377

Files:
  include/llvm/IR/BasicBlock.h
  lib/IR/BasicBlock.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31377.93087.patch
Type: text/x-patch
Size: 11910 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170326/bb6dcfec/attachment.bin>