[PATCH] D28215: Add check for BSD when setting LIB_NAMES for GNU ld

Andrew Wilkins via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 25 23:11:12 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL298798: Add check for BSD when setting LIB_NAMES for GNU ld (authored by axw).

Changed prior to commit:
  https://reviews.llvm.org/D28215?vs=82796&id=93066#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D28215

Files:
  llvm/trunk/tools/llvm-shlib/CMakeLists.txt


Index: llvm/trunk/tools/llvm-shlib/CMakeLists.txt
===================================================================
--- llvm/trunk/tools/llvm-shlib/CMakeLists.txt
+++ llvm/trunk/tools/llvm-shlib/CMakeLists.txt
@@ -37,7 +37,7 @@
 add_llvm_library(LLVM SHARED DISABLE_LLVM_LINK_LLVM_DYLIB SONAME ${SOURCES})
 
 list(REMOVE_DUPLICATES LIB_NAMES)
-if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux" OR MINGW) # FIXME: It should be "GNU ld for elf"
+if(("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux") OR (MINGW) OR ("${CMAKE_SYSTEM_NAME}" STREQUAL "FreeBSD") OR ("${CMAKE_SYSTEM_NAME}" STREQUAL "DragonFly")) # FIXME: It should be "GNU ld for elf"
   # GNU ld doesn't resolve symbols in the version script.
   set(LIB_NAMES -Wl,--whole-archive ${LIB_NAMES} -Wl,--no-whole-archive)
 elseif("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28215.93066.patch
Type: text/x-patch
Size: 814 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170326/275b6d3a/attachment.bin>


More information about the llvm-commits mailing list