[PATCH] D31364: LTO: Reduce memory consumption by creating an in-memory symbol table for InputFiles. NFCI.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

Just a couple of notes.



================
Comment at: llvm/lib/LTO/LTO.cpp:515
-
-  if (!Conf.OverrideTriple.empty())
-    M.setTargetTriple(Conf.OverrideTriple);
----------------
This may appear to not be NFC but it looks like this part has already been moved to the backend.


================
Comment at: llvm/lib/LTO/LTO.cpp:601
+      if (!IRName.empty()) {
+        auto GUID = GlobalValue::getGUID(GlobalValue::getGlobalIdentifier(
+            IRName, GlobalValue::ExternalLinkage, ""));
----------------
This is not actually NFC but a fix for a bug found by a colleague. I'll split it out into a separate change later.


https://reviews.llvm.org/D31364