[PATCH] D30998: [globalisel][tablegen] Handle LLVM_BUILD_GLOBAL_ISEL=OFF by emitting an empty tablegen-erated file.

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 19:03:11 PDT 2017


ab added a comment.

What do you think of moving the class declaration to the .cpp file ?  I don't think we need to export anything more than a "createAArch64InstructionSelector" function in AArch64.h; it was a mistake for me to put the class in the header in the first place.

That would get rid of the ifdef problem.


https://reviews.llvm.org/D30998





More information about the llvm-commits mailing list