[PATCH] D31352: Linker: Mark non-prevailing dllexport symbols as exported with a linker flag.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 14:41:21 PDT 2017

On Fri, Mar 24, 2017 at 2:14 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> This has the disadvantage that now two parts of the llvm are responsible
> for converting dllexport to linker directives (even if they share the
> function they call).
> I would prefer your previous solution or for the linker to keep a
> dllexport declaration in the IR.

That proposal has the disadvantage that it breaks StripFunctionPrototypes
and GlobalDCE. I thought we covered that in the discussion somewhere.

I like this change as is. It's the minimal change necessary to make
progress without changing any models.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170324/6f105641/attachment.html>

More information about the llvm-commits mailing list