[PATCH] D31270: [wip] IR: Move linker options to top-level global metadata and remove dllexport storage class.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 13:08:12 PDT 2017


On Fri, Mar 24, 2017 at 1:01 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Peter Collingbourne <peter at pcc.me.uk> writes:
>
> > Right. In principle we have an analogous situation in ELF: the IR may
> > contain a declaration such as:
> >
> > declare hidden void @foo()
> >
> > and that could have an effect on foo's visibility (assuming it is
> >hidden)
> > depending on whether the foo declaration was dropped.
>
> This suggests another way to implement this. Say that declations can have
> dllexport and that it is invalid to drop them.
>

That was one of the suggestions on the bug, but I'm not sure if it is the
way to go because it would introduce yet another constraint on valid IR
transformations. All things being equal I'd prefer to implement this in a
way that does not add constraints.

Thanks,
-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170324/dc5ac6ef/attachment.html>


More information about the llvm-commits mailing list