[PATCH] D31346: [SDAG] Fix Stale SDNode usage in visitAND

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 12:02:39 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3542
+
       SDValue NewLoad(Load, 0);
       if (Load->getExtensionType() == ISD::EXTLOAD) {
----------------
Duplicate SDValue(Load, 0) - change to:
```
SDValue NewLoad(Load, 0);
CombineTo(N, NewLoad);
```

??


================
Comment at: test/CodeGen/SystemZ/pr32372.ll:4
+
+define void @autogen_SD11045(i8*) {
+; CHECK-LABEL: autogen_SD11045:
----------------
Rename to pr32372 ? Any further cleanup possible?


https://reviews.llvm.org/D31346





More information about the llvm-commits mailing list