[PATCH] D31266: [sancov] fixing too aggressive instrumentation elimination

Mike Aizatsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 09:12:40 PDT 2017


aizatsky added inline comments.


================
Comment at: lib/Transforms/Instrumentation/SanitizerCoverage.cpp:422
   }
 
   return true;
----------------
kcc wrote:
> what if you add here something like this: 
>  for (const BasicBlock *SUCC : make_range(succ_begin(BB), succ_end(BB))) {
>     if (PDT->dominates(SUCC, BB))
>       return false;
>   }
Done. Also rearranged comments. PTAL.


https://reviews.llvm.org/D31266





More information about the llvm-commits mailing list