[lld] r298675 - Return early.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 18:13:30 PDT 2017


Author: ruiu
Date: Thu Mar 23 20:13:30 2017
New Revision: 298675

URL: http://llvm.org/viewvc/llvm-project?rev=298675&view=rev
Log:
Return early.

Modified:
    lld/trunk/ELF/Relocations.cpp

Modified: lld/trunk/ELF/Relocations.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Relocations.cpp?rev=298675&r1=298674&r2=298675&view=diff
==============================================================================
--- lld/trunk/ELF/Relocations.cpp (original)
+++ lld/trunk/ELF/Relocations.cpp Thu Mar 23 20:13:30 2017
@@ -593,10 +593,12 @@ static int64_t computeAddend(const elf::
 template <class ELFT>
 static void reportUndefined(SymbolBody &Sym, InputSectionBase &S,
                             typename ELFT::uint Offset) {
+  if (Config->UnresolvedSymbols == UnresolvedPolicy::IgnoreAll)
+    return;
+
   bool CanBeExternal = Sym.symbol()->computeBinding() != STB_LOCAL &&
                        Sym.getVisibility() == STV_DEFAULT;
-  if (Config->UnresolvedSymbols == UnresolvedPolicy::IgnoreAll ||
-      (Config->UnresolvedSymbols == UnresolvedPolicy::Ignore && CanBeExternal))
+  if (Config->UnresolvedSymbols == UnresolvedPolicy::Ignore && CanBeExternal)
     return;
 
   std::string Msg = S.getLocation<ELFT>(Offset) + ": undefined symbol '" +




More information about the llvm-commits mailing list