[PATCH] D31274: Remove an optimization to set the TLS module index to 1.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 17:12:39 PDT 2017


ruiu added a comment.

Could you explain the following expression for me? I think I understand `!Config->Pic` and `Config->Emachine == EM_ARM`, but why `!Body.isPreemptible()`?

  if (!Body.isPreemptible() && !Config->Pic && Config->EMachine == EM_ARM)

A symbol passed to this expression is somewhat arbitrary (it's just the first symbol that happened to this function), so it seems odd to me that that affects the decision how we set up the TLS module index.


https://reviews.llvm.org/D31274





More information about the llvm-commits mailing list