[PATCH] D31042: Allow DataLayout to specify addrspace for allocas.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: docs/LangRef.rst:1816
+``A<address space``
+    Specifies the address space of the result for the stack. Defaults to the
+    default address space of 0.
----------------
arsenm wrote:
> efriedma wrote:
> > "the address space of the result for the stack" is a little unclear.
> I wasn't sure about referring to the stack at all. Should I rename everything added that says stack with alloca (e.g DL.getStackAddrSpace() -> DL.getAllocaAddrSpace()?)
Well, in many contexts, it isn't precisely clear what the stack refers to... and there's a bunch of other stuff conventionally stored on the stack which could be stored elsewhere.  Maybe better to just call it the address-space of allocas, I guess?

Even assuming the meaning of "the stack" is clear, the sentence is missing something: it doesn't mention allocation anywhere.


https://reviews.llvm.org/D31042