[PATCH] D31270: [wip] IR: Move linker options to top-level global metadata and remove dllexport storage class.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 10:41:39 PDT 2017


pcc added a comment.

> Maintaining exports in a separate linker flag list makes it hard for these tools to determine which things are exported.

Only barely: such a (hypothetical) tool can easily enough parse the linker options list.

> Lastly, this is a minor bug in /msvclto, a feature that is only intended to exist until LLD can write PDBs. I feel like it just doesn't justify a representation change.

The alternatives that were discussed on the bug were also representational changes, and imposed new burdens on passes. That seems less justifiable for the sake of the /msvclto feature.


https://reviews.llvm.org/D31270





More information about the llvm-commits mailing list