[PATCH] D31243: [AArch64] [Assembler] option to disable negative immediate conversions

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 06:24:21 PDT 2017


samparker added a comment.

Hi Sanne,

I think just the testing needs tightening up. Should we also be changing (and testing) the compare immediate aliases too?

cheers,
sam



================
Comment at: test/MC/AArch64/alias-addsubimm.s:5
 // CHECK: sub w0, w2, #2, lsl #12
+// CHECK-NO-NEG-IMM: instruction requires: NegativeImmediates
         sub w0, w2, #2, lsl 12
----------------
There's no RUN line that checks CHECK-NO-NEG-IMM.


https://reviews.llvm.org/D31243





More information about the llvm-commits mailing list