[PATCH] D29598: LLVM Changes for alloc_align

Marina Yatsina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 01:52:58 PDT 2017

myatsina added inline comments.

Comment at: include/llvm/IR/IRBuilder.h:1879
+    Value *IsPositive =
+        CreateICmp(CmpInst::ICMP_UGT, Alignment,
+                   ConstantInt::get(Alignment->getType(), 0), "ispositive");
Sorry, I missed this one in my previous comment.
Now, that we are creating a signed cast, the comparison should be signed as well (ICMP_SGT). 
This will also affect the tests in the clang part of the review.


More information about the llvm-commits mailing list