[PATCH] D31145: [Outliner] Fix compile-time overhead for candidate choice

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

- This looks good to me.
- +1 to the benefit function getting the parent passed in.
- I'd replace the `FIXME`s with `TODO`, as they are really bugs but possible improvements (as far as I could understand)
- Superficially the suffixtree operations look okay to me, but I leave the judgement to the experts (=you).



================
Comment at: lib/CodeGen/MachineOutliner.cpp:611
+      // We didn't, so look at its parent.
+      SuffixTreeNode *Parent = Leaf->Parent;
 
----------------
Maybe use a reference as Parent cannot be nullptr.


https://reviews.llvm.org/D31145