[PATCH] D31267: [codeview] Move type index remapping logic to type merger

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 16:33:25 PDT 2017

zturner accepted this revision.
zturner added inline comments.

Comment at: lib/DebugInfo/CodeView/TypeStreamMerger.cpp:163
+Error TypeStreamMerger::visitKnownRecord(CVType &, ModifierRecord &R) {
+  return writeRecord(R, remapIndex(R.ModifiedType));
I forgot why we store `LastError` and proceed through the type stream, instead of just returning the error right away and failing.  Do you happen to know?


More information about the llvm-commits mailing list