[PATCH] D31143: Set the prof weight correctly for call instructions in DeadArgumentElimination.

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 14:06:43 PDT 2017


danielcdh added inline comments.


================
Comment at: lib/IR/Instruction.cpp:659
+         "Can only set weights for call instruciton");
+  if (W == 0)
+    return;
----------------
eraman wrote:
> Why is this guard needed? Is there a difference in handling an instruction with no metadata and one with a call weight of 0?
It should not be needed, removed.


https://reviews.llvm.org/D31143





More information about the llvm-commits mailing list