[PATCH] D31124: AMDGPU/SI: Add lane tracking to SI Scheduler

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 12:59:20 PDT 2017

rampitec added inline comments.

Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:1635
+SIScheduleBlockScheduler::getPairsForReg(SmallVector<RegisterMaskPair, 8> ToAppend,
+                                         unsigned Reg, LaneBitmask Mask)
ToAppend is passed by value... As far as I understand it should not work, i.e. it should not return any values.

Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:1664
+SmallVector<RegisterMaskPair, 8>
+SIScheduleBlockScheduler::getPairsForRegs(const SmallVector<RegisterMaskPair, 8> Regs)
Argument needs to be reference.



More information about the llvm-commits mailing list