[PATCH] D31220: [builtins][ARM] Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

Some of the implementations are not going to build in thumb1 mode, but would in thumb2, which is why we didnt do this uniformly.  I think we need to preserve that, or rewrite the functions.



================
Comment at: lib/builtins/assembly.h:105
+#define USE_THUMB_1
+#endif
+#define DEFINE_CODE_MODE .thumb
----------------
Is there a reason to use this alternate macro rather than directly using `__thumb2__` and `__thumb__` and ordering the sources to prefer thumb2, thumb, arm?


https://reviews.llvm.org/D31220