[llvm] r298523 - Rename helper functions in DwarfExpression to be less misleading (NFC)

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 10:19:55 PDT 2017


Author: adrian
Date: Wed Mar 22 12:19:55 2017
New Revision: 298523

URL: http://llvm.org/viewvc/llvm-project?rev=298523&view=rev
Log:
Rename helper functions in DwarfExpression to be less misleading (NFC)

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.h

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.cpp?rev=298523&r1=298522&r2=298523&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.cpp Wed Mar 22 12:19:55 2017
@@ -32,7 +32,7 @@ void DwarfExpression::addReg(int DwarfRe
   }
 }
 
-void DwarfExpression::addRegIndirect(int DwarfReg, int Offset) {
+void DwarfExpression::addBReg(int DwarfReg, int Offset) {
   assert(DwarfReg >= 0 && "invalid negative dwarf register number");
   if (DwarfReg < 32) {
     emitOp(dwarf::DW_OP_breg0 + DwarfReg);
@@ -241,7 +241,7 @@ bool DwarfExpression::addMachineRegExpre
       if (FBReg)
         addFBReg(SignedOffset);
       else
-        addRegIndirect(Reg.DwarfRegNo, SignedOffset);
+        addBReg(Reg.DwarfRegNo, SignedOffset);
 
       ExprCursor.consume(2);
       break;
@@ -254,7 +254,7 @@ bool DwarfExpression::addMachineRegExpre
     if (FBReg)
       addFBReg(0);
     else
-      addRegIndirect(Reg.DwarfRegNo, 0);
+      addBReg(Reg.DwarfRegNo, 0);
     ExprCursor.take();
     break;
   }

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.h?rev=298523&r1=298522&r2=298523&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.h (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.h Wed Mar 22 12:19:55 2017
@@ -122,10 +122,10 @@ protected:
   /// current function.
   virtual bool isFrameRegister(const TargetRegisterInfo &TRI, unsigned MachineReg) = 0;
 
-  /// Emit a dwarf register operation.
+  /// Emit a DW_OP_reg operation.
   void addReg(int DwarfReg, const char *Comment = nullptr);
-  /// Emit an (double-)indirect dwarf register operation.
-  void addRegIndirect(int DwarfReg, int Offset);
+  /// Emit a DW_OP_breg operation.
+  void addBReg(int DwarfReg, int Offset);
   /// Emit DW_OP_fbreg <Offset>.
   void addFBReg(int Offset);
 




More information about the llvm-commits mailing list