[PATCH] D30150: AMDGPU/SI: Update colorEndsAccordingToDependencies

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 10:14:48 PDT 2017


vpykhtin added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:840
+  // everything in one block.
+  if (*std::max_element(CurrentBottomUpReservedDependencyColoring.begin(),
+                        CurrentBottomUpReservedDependencyColoring.end()) == 0 &&
----------------
max_element can return end iterator only if the range is empty, so could you place an assert for this before these comparisons?


Repository:
  rL LLVM

https://reviews.llvm.org/D30150





More information about the llvm-commits mailing list