[PATCH] D31246: Send ANSI color codes only to TTYs

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 10:06:49 PDT 2017


zturner added a comment.

In https://reviews.llvm.org/D31246#707656, @chandlerc wrote:

> But we use this to send color codes to temporary files that capture output for build systems and such when -fcolor-diagnostics is explicitly provided? (As an example...)


That's strange, because everyone I asked thought that the `raw_ostream` stuff already worked this way -- i.e. doesn't send color if the destination doesn't support it.  Is there a currently accepted practice for writing FileCheck test against tools that output color?  Should every such tool have an explicit `-no-color` option?


https://reviews.llvm.org/D31246





More information about the llvm-commits mailing list