[PATCH] D30980: [GlobalISel][X86] support G_FRAME_INDEX instruction selection.

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 17:10:10 PDT 2017


ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!
Looks like the test has a file mode svn prop, maybe you can undo that?



================
Comment at: lib/Target/X86/X86LegalizerInfo.cpp:72
 
-  const LLT p0 = LLT::pointer(0, 64);
+  const LLT p0 = LLT::pointer(0, TM.getPointerSize() * 8);
   const LLT s8 = LLT::scalar(8);
----------------
Maybe check STI->isTarget64BitILP32 so that you don't have to carry around a TargetMachine?


Repository:
  rL LLVM

https://reviews.llvm.org/D30980





More information about the llvm-commits mailing list