[llvm] r298439 - GlobalISel: widen booleans by zero-extending to a byte.

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 15:21:24 PDT 2017


> On Mar 21, 2017, at 15:19, Tim Northover <tnorthover at apple.com> wrote:
> 
>> Yep. Sorry, I didn't realise AMDGPU used -1 or I'd have done that here and added a test (I thought it was untestable at this stage). I'll get onto it.
> 
> OK, it turns out it really is untestable (at least without significantly enhancing AMDGPU's understanding of legalization elsewhere, which is beyond my ken). I've got the change handy though, would you like me to commit without a test or are you planning to do some work in this area soon?
> 
> Cheers.
> 
> Tim.

I’ll make a note of it for when I get there, so go ahead. We had a few boolean type helper functions in SelectionDAG which probably should have equivalents

-Matt


More information about the llvm-commits mailing list