[PATCH] D30904: Allow suppressing host and target info in VersionPrinter

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 13:04:53 PDT 2017


chandlerc added a comment.

In https://reviews.llvm.org/D30904#706747, @compnerd wrote:

> I think that the idea that you propose is good, however, I think that may be better to do as a follow up.  This would get the immediate benefit for the tooling, and we can work out a nicer way to expose the information to the other users.  Making it something which each app does means that we would need to change all the apps as well, which would be a much larger change.


OK, but if you want to go the current route, it needs more work too.

First, there is no corresponding CMake change to allow us to set the macro.

But once you do that, we'll get to the core issue I think I have here. I don't think we want to lose this information from tools like opt, llc, and clang where it is *very* useful. So that'll cause the default for this CMake variable to be set in the direction that doesn't get us any benefit by default. If that's enough for you, then OK. But if you want this to be available for tooling *by default* I think we need to at least do the initial work of making this controllable to avoid regressing the debug information provided in Clang and other binary's version string.


Repository:
  rL LLVM

https://reviews.llvm.org/D30904





More information about the llvm-commits mailing list