[PATCH] D30904: Allow suppressing host and target info in VersionPrinter

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 12:42:34 PDT 2017


I really like Chandler's suggestion here. I might be oversimplifying the problem, but I actually don't think it would be too difficult to implement. I think all you would need to do is pull the VersionPrinter out of CommandLine.cpp into its own header and provide "simplified" and "detailed" derivatives of it.

-Chris

> On Mar 21, 2017, at 12:16 PM, Chandler Carruth via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> chandlerc added a comment.
> 
> This seems like a totally nice direction, but I wonder if I could convince you to scope creep this a bit?
> 
> I feel like this shouldn't be guarded by a macro at all. Instead, for tools where it makes sense, we should have an API they can call (perhaps instead of or in addition to this) which provides this level of information in their version strings.
> 
> For example, I don't ever want clang-format or FileCheck to care about this. But I'd rather like opt, llc, and clang to always show it. And for those, it costs them nothing as this code is going to get linked in anyways.
> 
> What do you think?
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D30904
> 
> 
> 



More information about the llvm-commits mailing list