[PATCH] D30957: [CMake] Support single target builtins build on Darwin

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 10:50:01 PDT 2017


beanz added a comment.

One minor style comment, otherwise looks good to me.



================
Comment at: runtimes/CMakeLists.txt:193
                                           ${${target}_extra_args}
+                               TOOLCHAIN_TOOLS clang;lld;llvm-ar;llvm-ranlib
                                PASSTHROUGH_PREFIXES COMPILER_RT
----------------
This shouldn't need to be semi-colon separated. Space separated should work because `TOOLCHAIN_TOOLS` is a list parameter.


Repository:
  rL LLVM

https://reviews.llvm.org/D30957





More information about the llvm-commits mailing list