[PATCH] D31032: [LoadCombine] Avoid analysing dead basic blocks

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added a comment.

In https://reviews.llvm.org/D31032#706349, @KennethH wrote:

> I have updated according to most of the comments.


Note: You are still calling it "IsAlive", which again, does not really tell anyone what it is supposed to mean :)
However, ...

> I think that the re-factoring of all basic block passes to function passed should be done as a separate task.

That's fine, if you want to fix it by making BB passes more expensive and doing another walk of all BB's, you are welcome to.
This, to me, feels like a hack-around to try to paper over how these passes operate.
Someone else can approve that if they are comfortable with it :)


https://reviews.llvm.org/D31032