[PATCH] D31182: [InstCombine] fadd double (sitofp x), y check that the promotion is valid

[Sanjay Patel via Phabricator via llvm-commits]

spatel added reviewers: hfinkel, jmolloy.
spatel added a comment.

Before getting to any details about the patch, we need to address the question raised in PR27036: why are we doing this transform in InstCombine at all? The assumption is that an integer add is more canonical and/or cheaper than an FP add. Is that universally true?


https://reviews.llvm.org/D31182