[PATCH] D31188: [AntiDepBreaker] Do not use getPristineRegs for marking live registers.

[Tim Shen via Phabricator via llvm-commits]

timshen added inline comments.


================
Comment at: llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp:165
+  const auto &MFI = MF.getFrameInfo();
+  const auto HasSlot = [this, &MFI](unsigned Reg) {
+    const auto &CSI = MFI.getCalleeSavedInfo();
----------------
hfinkel wrote:
> Should this return an Optional (or similar)? It seems unfortunate to check MF.getFrameInfo().isCalleeSavedInfoValid() here and also check MFI.isCalleeSavedInfoValid() in the if below.
> 
Good catch! I turned the first isCalleeSavedInfoValid into an assert, since it's guarded by the second call.


https://reviews.llvm.org/D31188