[llvm] r298368 - [AMDGPU] Iterative scheduling infrastructure + minimal registry scheduler

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 06:42:58 PDT 2017


On 03/21/2017 08:15 AM, Valery Pykhtin via llvm-commits wrote:
> Author: vpykhtin
> Date: Tue Mar 21 08:15:46 2017
> New Revision: 298368
>
> URL: http://llvm.org/viewvc/llvm-project?rev=298368&view=rev
> Log:
> [AMDGPU] Iterative scheduling infrastructure + minimal registry scheduler

Hi Valery,

In the future, please make your commit messages more explanatory. 
"Iterative scheduling infrastructure + minimal registry scheduler" tells 
me next to nothing about what this is or how it works. It is obviously 
an extensive addition/change. The review had a good summary, and that 
should have appeared here (updated to reflect any changes made as a 
result of the code review).

I'd appreciate it if you would reply to this thread with the updated 
summary.

Thanks,
Hal

>
> Differential revision: https://reviews.llvm.org/D31046
>
> Added:
>      llvm/trunk/lib/Target/AMDGPU/GCNIterativeScheduler.cpp
>      llvm/trunk/lib/Target/AMDGPU/GCNIterativeScheduler.h
>      llvm/trunk/lib/Target/AMDGPU/GCNMinRegStrategy.cpp
>      llvm/trunk/lib/Target/AMDGPU/GCNRegPressure.cpp
>      llvm/trunk/lib/Target/AMDGPU/GCNRegPressure.h
>      llvm/trunk/test/CodeGen/AMDGPU/schedule-regpressure-limit2.ll
> Modified:
>      llvm/trunk/lib/Target/AMDGPU/AMDGPUSubtarget.h
>      llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
>      llvm/trunk/lib/Target/AMDGPU/CMakeLists.txt
>      llvm/trunk/lib/Target/AMDGPU/GCNSchedStrategy.cpp
>      llvm/trunk/lib/Target/AMDGPU/GCNSchedStrategy.h
>      llvm/trunk/test/CodeGen/AMDGPU/schedule-regpressure-limit.ll
>
> Modified: llvm/trunk/lib/Target/AMDGPU/AMDGPUSubtarget.h
> ...
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list