[llvm] r298308 - Make implementation details in DwarfExpression protected. (NFC)

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 14:34:19 PDT 2017


Author: adrian
Date: Mon Mar 20 16:34:19 2017
New Revision: 298308

URL: http://llvm.org/viewvc/llvm-project?rev=298308&view=rev
Log:
Make implementation details in DwarfExpression protected. (NFC)

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.h

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.h?rev=298308&r1=298307&r2=298308&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.h (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.h Mon Mar 20 16:34:19 2017
@@ -102,13 +102,6 @@ protected:
   /// Add masking operations to stencil out a subregister.
   void maskSubRegister();
 
-public:
-  DwarfExpression(unsigned DwarfVersion) : DwarfVersion(DwarfVersion) {}
-  virtual ~DwarfExpression() {};
-
-  /// This needs to be called last to commit any pending changes.
-  void finalize();
-
   /// Output a dwarf operand and an optional assembler comment.
   virtual void emitOp(uint8_t Op, const char *Comment = nullptr) = 0;
   /// Emit a raw signed value.
@@ -147,6 +140,13 @@ public:
   /// expression.  See PR21176 for more details.
   void addStackValue();
 
+public:
+  DwarfExpression(unsigned DwarfVersion) : DwarfVersion(DwarfVersion) {}
+  virtual ~DwarfExpression() {};
+
+  /// This needs to be called last to commit any pending changes.
+  void finalize();
+
   /// Emit an indirect dwarf register operation for the given machine register.
   /// \return false if no DWARF register exists for MachineReg.
   bool addMachineRegIndirect(const TargetRegisterInfo &TRI, unsigned MachineReg,
@@ -206,15 +206,14 @@ public:
 class DebugLocDwarfExpression : public DwarfExpression {
   ByteStreamer &BS;
 
-public:
-  DebugLocDwarfExpression(unsigned DwarfVersion, ByteStreamer &BS)
-      : DwarfExpression(DwarfVersion), BS(BS) {}
-
   void emitOp(uint8_t Op, const char *Comment = nullptr) override;
   void emitSigned(int64_t Value) override;
   void emitUnsigned(uint64_t Value) override;
   bool isFrameRegister(const TargetRegisterInfo &TRI,
                        unsigned MachineReg) override;
+public:
+  DebugLocDwarfExpression(unsigned DwarfVersion, ByteStreamer &BS)
+      : DwarfExpression(DwarfVersion), BS(BS) {}
 };
 
 /// DwarfExpression implementation for singular DW_AT_location.
@@ -223,13 +222,13 @@ const AsmPrinter ≈
   DwarfUnit &DU;
   DIELoc ¨
 
-public:
-  DIEDwarfExpression(const AsmPrinter &AP, DwarfUnit &DU, DIELoc &DIE);
   void emitOp(uint8_t Op, const char *Comment = nullptr) override;
   void emitSigned(int64_t Value) override;
   void emitUnsigned(uint64_t Value) override;
   bool isFrameRegister(const TargetRegisterInfo &TRI,
                        unsigned MachineReg) override;
+public:
+  DIEDwarfExpression(const AsmPrinter &AP, DwarfUnit &DU, DIELoc &DIE);
   DIELoc *finalize() {
     DwarfExpression::finalize();
     return ¨




More information about the llvm-commits mailing list