[PATCH] D30699: [ELF] - Stop producing broken output for R_386_GOT32X relocation.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 08:02:17 PDT 2017

ruiu added a comment.

So, you were sending contradicting messages. You should have said "no, his comment is wrong" when asked if the H.J. Lu's comment was correct, because that is wrong from the point of view of your documentation. Anyway, we are finally on the same page. Please make a change to R_386_GOT32 first, so that the relocation is handled as described in https://github.com/hjl-tools/x86-psABI/wiki/intel386-psABI-draft.pdf. The R_386_GOT32X optimization is optional, and we don't need to do that at the moment.


More information about the llvm-commits mailing list