[lld] r298078 - [ELF] - Simplify logic of creating "COMMON" section.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 20 01:09:32 PDT 2017
>>It probably better then form sugested by compiler
>> if ((In<ELFT>::Common = createCommonSection<ELFT>()))
>I don't know why I missed this during code review, but adding parentheses isn't a good way to fix the warning. You should use >more vertical space.
> In<ELFT>::Common = createCommonSection<ELFT>();
> if (In<ELFT>::Common)
It was not on review, because there was no warning for me during development.
Here I was mean that when I fixed that warning after commit, compiler at first suggested me to add parantheses, but I did not do that (I knew we dont use this method) and used the same way as in your suggestion to fix the warning finally (https://reviews.llvm.org/rL298086).
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits