[PATCH] D31090: [ELF] - Detemplate MipsGotSection<ELFT>

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 16:42:36 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Config.h:170
   bool is64() const { return EKind == ELF64LEKind || EKind == ELF64BEKind; }
+  unsigned size() const { return is64() ? 8 : 4; };
 
----------------
ruiu wrote:
> This is a sort of unrelated refactoring, so let's not do this in this patch. (Besides `size` is not a good name.)
I added Config->Wordsize, so please use it.


https://reviews.llvm.org/D31090





More information about the llvm-commits mailing list